datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard
verified publisher icon apache

build: Add spark-4.0 profile and shims

Open kazuyukitanimura opened this issue 1 year ago • 7 comments

Which issue does this PR close?

Part of https://github.com/apache/datafusion-comet/issues/372

Rationale for this change

To be ready for Spark 4.0

What changes are included in this PR?

This PR adds the spark-4.0 profile and shims

How are these changes tested?

This is an initial commit. Tests with the spark-4.0 profile do not pass yet. Tests for spark-3.x should pass.

kazuyukitanimura avatar May 09 '24 17:05 kazuyukitanimura

@viirya @andygrove Please approve to start CI

kazuyukitanimura avatar May 09 '24 17:05 kazuyukitanimura

Triggered.

viirya avatar May 09 '24 17:05 viirya

@viirya @andygrove Is there a way to start CI without bothering you?

kazuyukitanimura avatar May 09 '24 21:05 kazuyukitanimura

I remember only the first-time contributors need approval to trigger CI.

viirya avatar May 09 '24 21:05 viirya

@viirya @andygrove passed all the tests on my personal github actions It looks still not triggering here. Maybe need a committership to start CI with github actions workflow change?

kazuyukitanimura avatar May 11 '24 11:05 kazuyukitanimura

Triggered CI pipelines.

viirya avatar May 11 '24 17:05 viirya

@viirya Please take another look cc @andygrove @comphead

kazuyukitanimura avatar May 20 '24 20:05 kazuyukitanimura

Thank you @viirya Please take a final look 32bc314

kazuyukitanimura avatar May 23 '24 05:05 kazuyukitanimura

@kazuyukitanimura I think you can try to merge this.

viirya avatar May 28 '24 18:05 viirya

Thank you @viirya merged

kazuyukitanimura avatar May 28 '24 19:05 kazuyukitanimura