datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

build: bump spark version to 3.4.3

Open huaxingao opened this issue 1 year ago • 1 comments

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

huaxingao avatar Apr 19 '24 20:04 huaxingao

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.18%. Comparing base (de8fe45) to head (f6dcdd7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #292   +/-   ##
=========================================
  Coverage     34.18%   34.18%           
  Complexity      851      851           
=========================================
  Files           116      116           
  Lines         38570    38570           
  Branches       8531     8531           
=========================================
  Hits          13187    13187           
  Misses        22612    22612           
  Partials       2771     2771           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 21 '24 15:05 codecov-commenter

@viirya I didn't see any changes between 3.4.2.diff and 3.4.3.diff except some index changes, line number changes and the changes I added

@@ -1128,7 +1130,7 @@ abstract class ParquetQuerySuite extends QueryTest with ParquetTest with SharedS
             .where(s"a < ${Long.MaxValue}")
             .collect()
         }
-        assert(exception.getCause.getCause.isInstanceOf[SchemaColumnConvertNotSupportedException])
+        assert(exception.getMessage.contains("Column: [a], Expected: bigint, Found: INT32"))
       }
     }
   }

huaxingao avatar May 29 '24 03:05 huaxingao

@viirya I didn't see any changes between 3.4.2.diff and 3.4.3.diff except some index changes, line number changes and the changes I added

Okay, that's great. I thought that there might be some conflicts between 3.4.2 and 3.4.3 tests, but seems we don't have much changes between the two patch versions.

viirya avatar May 29 '24 05:05 viirya

Thanks @kazuyukitanimura @parthchandra @viirya

huaxingao avatar May 29 '24 06:05 huaxingao