creadur-rat icon indicating copy to clipboard operation
creadur-rat copied to clipboard
verified publisher icon apache

RAT-398: deprecate methods in Ant report

Open Claudenw opened this issue 11 months ago • 6 comments

Deprecated Ant methods and ensured that deprecation message appears in log.

Closes RAT-398

Claudenw avatar Mar 16 '25 15:03 Claudenw

We are still in the analysis why the tests fail and should not merge this PR until the problems are fixed.

ottlinger avatar Mar 24 '25 09:03 ottlinger

@ottlinger yes, agree. I just did a quick review on this PR.

jbonofre avatar Mar 24 '25 09:03 jbonofre

@jbonofre do you have an idea concerning the failing test? There were no changes in the test; it runs well on master, but fails in this branch. The junit-update did not bring in the problem as I checked locally.

@Claudenw over the weekend I thought maybe it is a timing issue and wanted to try to add a local call to GC as that fixed some of the other test failures before ..... really odd situation.

ottlinger avatar Mar 31 '25 08:03 ottlinger

@ottlinger @jbonofre I spent some time looking at this and discovered that there were a few junit4 annotations still in use. The one I was most concerned about was the the @Rule annotation. I removed all junit4 references and everything worked.

Claudenw avatar Apr 06 '25 13:04 Claudenw

@ottlinger @jbonofre does anyone see any reason not to merge this now?

Claudenw avatar Apr 06 '25 14:04 Claudenw

@Claudenw there are some other review comments ..... cool, that you seem to have fixed the jUnit problem!

ottlinger avatar Apr 06 '25 18:04 ottlinger