couchdb icon indicating copy to clipboard operation
couchdb copied to clipboard

Clean elixir build artifacts with `make clean`

Open jaydoane opened this issue 1 year ago • 1 comments

Overview

Stale Elixir dependencies can cause test failures after upgrading Erlang or Elixir, so remove them whenever we make clean.

Testing recommendations

Confirm it removes Elixir test artifacts.

❯ mix deps.compile

❯ tree -L 3 _build/
_build/
└── dev
    └── lib
        ├── b64url
        ├── bunt
        ├── couchdbtest
        ├── credo
        ├── file_system
        ├── httpotion
        ├── ibrowse
        ├── jason
        ├── jiffy
        ├── junit_formatter
        ├── jwtf
        └── ssl_verify_fun

15 directories, 0 files

❯ make clean

❯ tree -L 3 _build/
_build/

0 directories, 0 files

Related Issues or Pull Requests

Checklist

  • [x] Code is written and works correctly
  • [ ] Changes are covered by tests
  • [ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • [ ] Documentation changes were made in the src/docs folder
  • [ ] Documentation changes were backported (separated PR) to affected branches

jaydoane avatar Aug 21 '24 21:08 jaydoane

Don’t forget to updateMakefile.win 😉

big-r81 avatar Aug 21 '24 23:08 big-r81

+1 if the full CI passes (make a jenkins-... branch and use a git commit amend --no-edit to give it a new commit ID and push, no need for a PR even).

Mainly because previously we had some issues with elixir + clean not working: #4740

I updated Makefile.win and ran the full CI here and it seems to pass.

Is it possible that whatever was causing https://github.com/apache/couchdb/issues/4706 has been fixed, and this is now safe to merge?

jaydoane avatar Aug 30 '24 02:08 jaydoane

Thanks, Jay. Let’s merge it!

nickva avatar Aug 30 '24 02:08 nickva