cordova-plugin-camera icon indicating copy to clipboard operation
cordova-plugin-camera copied to clipboard

DATA_URL is improperly prefixed

Open Bobert-Brockson opened this issue 7 years ago • 12 comments

Getting a dataURL from the cordova-plugin-camera omits the 'data:'mimeType';base64, '

Bobert-Brockson avatar Jan 31 '19 19:01 Bobert-Brockson

This is currently the actual API behavior across all platforms. I do not think it is a bug since it is consistent across all platforms.

hazems avatar Feb 24 '19 10:02 hazems

It's a known issue https://issues.apache.org/jira/browse/CB-9819

jcesarmobile avatar Feb 25 '19 16:02 jcesarmobile

@jcesarmobile If we agree to have this supported across platforms, here is my Android support proposal: https://github.com/hazems/cordova-plugin-camera/commit/e6609c0b6a590a30ef7802826888693142576bee

hazems avatar Feb 26 '19 03:02 hazems

I personally agree, but for this kind of changes is recommended to send a mail to the dev list proposing it

jcesarmobile avatar Feb 26 '19 08:02 jcesarmobile

Sure will share it with the group.

hazems avatar Feb 27 '19 02:02 hazems

Sent to development group email.

hazems avatar Feb 27 '19 02:02 hazems

@imizaac A PR is created to fix this behavior across of all Camera platforms: https://github.com/apache/cordova-plugin-camera/pull/432

cc @jcesarmobile

hazems avatar Mar 17 '19 04:03 hazems

If anyone or @imizaac is interested in this fix, feel free to thumb up this PR which fixes this issue across all of Cordova supported platforms: https://github.com/apache/cordova-plugin-camera/pull/432

Thanks

hazems avatar Apr 07 '19 06:04 hazems

Any timeframe for this to get merged?

ruisilva450 avatar May 08 '19 11:05 ruisilva450

No.

janpio avatar May 08 '19 12:05 janpio

@ruisilva450 This is the PR that fix this issue across all platforms: https://github.com/apache/cordova-plugin-camera/pull/432

Please thumbs it up to show an interest in merging it.

hazems avatar May 09 '19 22:05 hazems

@ruisilva450 This is the PR that fix this issue across all platforms: #432

Please thumbs it up to show an interest in merging it.

I already saw that, has my thumbs up and that's why I'm asking 😃

ruisilva450 avatar May 10 '19 07:05 ruisilva450