commons-validator icon indicating copy to clipboard operation
commons-validator copied to clipboard

Switch to use commons-digester3

Open harrisric opened this issue 11 months ago • 8 comments

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • [/] Read the contribution guidelines for this project.
  • [/] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • [/] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • [/] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [/] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

Changed the dependency on commons-digester to use commons-digester3 instead.

I understand that this may be blocked for a later major version change similarly to #53 running japicmp:cmp yields the following output:

[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.23.1:cmp (default-cli) on project commons-validator: There is at least one incompatibility: org.apache.commons.digester.ObjectCreationFactory[org.apache.commons.digester.ObjectCreationFactory]:INTERFACE_REMOVED,org.apache.commons.validator.FormSetFactory:SUPERCLASS_REMOVED,org.apache.commons.validator.FormSetFactory:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE -> [Help 1]

harrisric avatar Feb 14 '25 14:02 harrisric