commons-pool icon indicating copy to clipboard operation
commons-pool copied to clipboard

Add failing tests to reproduce POOL-426

Open rajucomp opened this issue 1 month ago • 1 comments

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • [x] Read the contribution guidelines for this project.
  • [x] Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • [x] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

See https://issues.apache.org/jira/browse/POOL-426 for more details.

rajucomp avatar Dec 14 '25 21:12 rajucomp

@garydgregory @psteitz Requesting critical review for the fix for POOL-426. Thanks!

rajucomp avatar Dec 14 '25 21:12 rajucomp

Hi @psteitz Any thoughts on this one?

garydgregory avatar Dec 20 '25 20:12 garydgregory

Analysis looks correct to me. This plus revert of bugged fix for POOL-425 should work. I am having trouble getting the patch applied to the right branch. Will review and merge once fully tested. Thanks for the patch.

psteitz avatar Dec 24 '25 23:12 psteitz

I can cut a release candidate when we have a fix validated.

garydgregory avatar Dec 25 '25 01:12 garydgregory

Added a test for POOL-413 as well.

rajucomp avatar Dec 25 '25 12:12 rajucomp