commons-logging icon indicating copy to clipboard operation
commons-logging copied to clipboard

[LOGGING-173] remove Apache Avalon, defunct for over a decade

Open elharo opened this issue 5 years ago • 6 comments

elharo avatar Dec 14 '20 17:12 elharo

CI appears to need attention:

Error: Unable to process command '::set-env name=JAVA_HOME_16.0.0-ea.24_x64::/opt/hostedtoolcache/jdk/16.0.0-ea/x64' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: Unable to process command '::set-env name=JAVA_HOME::/opt/hostedtoolcache/jdk/16.0.0-ea/x64' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: Unable to process command '::set-env name=JAVA_HOME_16_0_0_EA_24_X64::/opt/hostedtoolcache/jdk/16.0.0-ea/x64' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: Unable to process command '::add-path::/opt/hostedtoolcache/jdk/16.0.0-ea/x64/bin' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
creating settings.xml with server-id: github; environment variables: username=$GITHUB_ACTOR, *** and gpg-passphrase=null
writing /home/runner/.m2/settings.xml

elharo avatar Dec 14 '20 17:12 elharo

This won't happen until master switches to 2.0 and changes the package name which will break this PR. Until then, we could split up this project into a multi-module component, needs thinking...

garydgregory avatar Dec 14 '20 18:12 garydgregory

@elharo Please rebase on master.

garydgregory avatar Dec 14 '20 19:12 garydgregory

When is that likely to happen?

elharo avatar Dec 14 '20 20:12 elharo

Well, I have no plans ATM to do so. But... if we release a new version that breaks binary compatibility, then we will have to change the package name and Maven coordinates, so that will be a source code change for call sites, which should/could be as simple as changing a package import from foo to foo2. Then, if we are going to bother going a major release, we should IMO break up this component into a multimodule project, which means that each module will be in its own package to make JPMS happy. If we did such a Maven modularization in 1.x while keeping the package names the same, then this would cause Java 9 and up to complain and maybe not even work since all the implementations are in the same package today. Any thoughts from you or the community?

garydgregory avatar Dec 15 '20 14:12 garydgregory

My personal thoughts are that this project has run its course. java.util.logging and SLF4J between them seem to serve the market. If it's not moving forward, then it's probably best to archive the repo and close the project.

elharo avatar Dec 15 '20 16:12 elharo