commons-lang icon indicating copy to clipboard operation
commons-lang copied to clipboard

Add missing exception javadoc/tests for some null arguments

Open dvmarcilio opened this issue 4 years ago • 3 comments

Hello! I added some missing javadoc for null arguments and wrote tests when they didn't exist. I tried to keep the diffs as small as possible and the sentences consistent. I will be happy to change anything if needed. Thanks.

dvmarcilio avatar Mar 26 '22 15:03 dvmarcilio

Hi @dvmarcilio & thank you for your PR. Let' hold off on this one. I want to normalize on using Java's Objects#requireNonNull().

garydgregory avatar Mar 26 '22 17:03 garydgregory

Codecov Report

Merging #869 (d071740) into master (3ac6bea) will increase coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #869      +/-   ##
============================================
+ Coverage     91.72%   91.73%   +0.01%     
- Complexity     7421     7423       +2     
============================================
  Files           188      188              
  Lines         15924    15924              
  Branches       2999     2999              
============================================
+ Hits          14606    14608       +2     
+ Misses          726      724       -2     
  Partials        592      592              
Impacted Files Coverage Δ
...main/java/org/apache/commons/lang3/ArrayUtils.java 95.84% <ø> (ø)
src/main/java/org/apache/commons/lang3/Range.java 91.20% <ø> (ø)
.../apache/commons/lang3/builder/ToStringBuilder.java 100.00% <ø> (ø)
...va/org/apache/commons/lang3/reflect/TypeUtils.java 60.80% <ø> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ac6bea...d071740. Read the comment docs.

codecov-commenter avatar Jul 10 '22 20:07 codecov-commenter

Hi @garydgregory. Thanks for pinging me. All should be fine now.

dvmarcilio avatar Jul 10 '22 20:07 dvmarcilio