commons-dbutils icon indicating copy to clipboard operation
commons-dbutils copied to clipboard
verified publisher icon apache

[COMMONSSITE-145]upgrade checkstyle

Open XenoAmess opened this issue 4 years ago • 1 comments

https://issues.apache.org/jira/browse/COMMONSSITE-145

XenoAmess avatar May 09 '21 16:05 XenoAmess

Coverage Status

Coverage increased (+0.02%) to 65.642% when pulling 7ef1d430439fe2a64e3542dac55a9897ce46b151 on xenoamess-fork:upgrade_checkstyle into c3db1e6dba63ea81201c7f9f454bdad65809b137 on apache:master.

coveralls avatar May 09 '21 16:05 coveralls

Closing as dependency upgrades for things like checkstyle are handled by a bot, and this particular version is woefully out of date this point.

thecarlhall avatar Nov 15 '22 13:11 thecarlhall

@thecarlhall it WAS the latest version 1.5 years ago. This is a 1.5 years unhandled pr, so as that jira ticket. Glad it be solved in other pr though. And there is never such goode bot to upgrade it as checkstyle's author always have nothing named backward compatibility, chaning this name this time and that attribute that time, more like a poet or something than a programmer. like this time he change scope to accessModifiers.

XenoAmess avatar Nov 15 '22 15:11 XenoAmess

Ahh, thanks for the call out about scope changing. Would you please update the PR without the checkstyle version change?

thecarlhall avatar Nov 15 '22 17:11 thecarlhall

Looks like the Checkstyle config change is already in the repo, so closing this PR.

thecarlhall avatar Dec 04 '22 14:12 thecarlhall