commons-daemon icon indicating copy to clipboard operation
commons-daemon copied to clipboard

Remove reference to IRC channel (no longer exists)

Open daveloyall opened this issue 2 years ago • 6 comments

If Apache Commons has an IRC presence somewhere, please disregard this PR and update the reference instead. I confirmed that the current reference leads to an empty IRC channel.

daveloyall avatar Nov 29 '23 22:11 daveloyall

@sebbASF Do you know?

garydgregory avatar Nov 30 '23 11:11 garydgregory

I have only ever used IRC for members meetings. I suspect there is no longer a Commons IRC channel (if there ever was one), but I am not 100% sure.

sebbASF avatar Nov 30 '23 12:11 sebbASF

Note that the README is automatically generated, so applying this patch may not work long-term

sebbASF avatar Nov 30 '23 12:11 sebbASF

Check, the plugin that generates the readme needs to be updated.

garydgregory avatar Nov 30 '23 12:11 garydgregory

And all the README files regenerated (every time the plugin is subsequently changed) ... there has to be a better way.

sebbASF avatar Nov 30 '23 12:11 sebbASF

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (470f048) 0.49% compared to head (ed1cc06) 0.49%. Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #123   +/-   ##
========================================
  Coverage      0.49%   0.49%           
  Complexity        1       1           
========================================
  Files             5       5           
  Lines           406     406           
  Branches         66      66           
========================================
  Hits              2       2           
  Misses          404     404           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 09 '23 14:12 codecov-commenter

Updated to commons-parent to pick up new templates with the IRC reference removed and regenerated the generated files.

markt-asf avatar May 15 '24 14:05 markt-asf