commons-crypto icon indicating copy to clipboard operation
commons-crypto copied to clipboard

[CRYPTO-156] - Common Class Padding and Transform

Open arturobernalg opened this issue 5 years ago • 3 comments

In order to avoid duplicate code and try to unify the transformation of the token i think it's necessary create the next class:

OpenSslTransform --> Utility code for dealing with different algorithm types OpenSslPadding --> Containg the enumeration of Cipher Algorithm Padding OpenSslAlgorithmMode --> Enumeration of Algorithm Mode. https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208 https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422 https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47 https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399

arturobernalg avatar Jan 05 '21 15:01 arturobernalg

Coverage Status

Coverage increased (+0.2%) to 82.834% when pulling a0230dadb62beb40255080250709640a5fb3331b on arturobernalg:feature/CRYPTO-156 into 9c76b2c2499ca30c4e3ed84c86afed0bd82e4a1e on apache:master.

coveralls avatar Jan 05 '21 15:01 coveralls

Any committer want to have a look at this? Seems to me like a code improvement.

aremily avatar May 19 '22 00:05 aremily

Any committer want to have a look at this? Seems to me like a code improvement.

I'll take a look this weekend. Nothing urgent IMO since it should all be private/internal.

garydgregory avatar May 19 '22 11:05 garydgregory