commons-collections icon indicating copy to clipboard operation
commons-collections copied to clipboard

Fix links in javadoc and documentations

Open marcwrobel opened this issue 3 years ago • 2 comments

  • fix broken links,
  • use direct links instead of redirects,
  • use HTTPS where possible.

marcwrobel avatar Aug 01 '22 21:08 marcwrobel

@kinow, thanks for your valuable input. I will rollback the fixes that are unnecessary and have a look at the commons-release-plugin / commons-build-plugin when I have some time.

marcwrobel avatar Aug 02 '22 20:08 marcwrobel

Codecov Report

Merging #325 (3afe82b) into master (7bf71f5) will decrease coverage by 0.05%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
- Coverage     86.00%   85.95%   -0.06%     
+ Complexity     4678     4676       -2     
============================================
  Files           288      288              
  Lines         13480    13480              
  Branches       1980     1980              
============================================
- Hits          11594    11587       -7     
- Misses         1325     1329       +4     
- Partials        561      564       +3     
Impacted Files Coverage Δ
...ava/org/apache/commons/collections4/ListUtils.java 87.09% <ø> (ø)
...commons/collections4/map/AbstractReferenceMap.java 88.88% <ø> (-2.60%) :arrow_down:
.../apache/commons/collections4/map/ReferenceMap.java 75.00% <ø> (ø)
...ons/collections4/sequence/SequencesComparator.java 95.34% <ø> (ø)
...apache/commons/collections4/trie/PatriciaTrie.java 50.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 25 '22 23:08 codecov-commenter

@kinow, is it better now I have rolled back the unnecessary fixes ?

marcwrobel avatar Oct 18 '22 13:10 marcwrobel

Normally changes where links are fixed in documentation are merged without being added to the change log, but given this change fixed links in so many files, I decided to add an entry and also credit you @marcwrobel . Thanks a lot for fixing these link and for updating the pull request :+1:

-Bruno

kinow avatar Oct 19 '22 01:10 kinow

Merged.

kinow avatar Oct 19 '22 01:10 kinow