commons-collections icon indicating copy to clipboard operation
commons-collections copied to clipboard
verified publisher icon apache

(chore) Fix minor typos

Open marcwrobel opened this issue 3 years ago • 5 comments

Fix various minor typos in :

  • project documentations,
  • javadoc and comments,
  • method attribute and variable names,
  • test method names.

marcwrobel avatar Jul 16 '22 08:07 marcwrobel

Codecov Report

Merging #323 (e22382a) into master (304a1bf) will decrease coverage by 0.05%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
- Coverage     85.98%   85.93%   -0.06%     
+ Complexity     4671     4669       -2     
============================================
  Files           289      289              
  Lines         13447    13447              
  Branches       1977     1977              
============================================
- Hits          11563    11556       -7     
- Misses         1323     1327       +4     
- Partials        561      564       +3
Impacted Files Coverage Δ
...va/org/apache/commons/collections4/ArrayStack.java 76.66% <ø> (ø)
.../org/apache/commons/collections4/ClosureUtils.java 100.00% <ø> (ø)
...g/apache/commons/collections4/ComparatorUtils.java 78.57% <ø> (ø)
...rg/apache/commons/collections4/FluentIterable.java 100.00% <ø> (ø)
...java/org/apache/commons/collections4/MapUtils.java 93.30% <ø> (ø)
...java/org/apache/commons/collections4/SetUtils.java 72.97% <ø> (ø)
...ache/commons/collections4/bag/SynchronizedBag.java 91.66% <ø> (ø)
...ommons/collections4/bag/SynchronizedSortedBag.java 25.00% <ø> (ø)
...mons/collections4/bidimap/AbstractDualBidiMap.java 97.19% <ø> (ø)
...ache/commons/collections4/bidimap/TreeBidiMap.java 85.85% <ø> (ø)
... and 39 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 16 '22 08:07 codecov-commenter

Holding off on this one until #320 is merged.

garydgregory avatar Jul 29 '22 12:07 garydgregory

@garydgregory, I just resolved the conflicts. #320 has been merged so this PR is ready for review.

marcwrobel avatar Aug 29 '22 19:08 marcwrobel

@garydgregory, conflicts resolved.

marcwrobel avatar Oct 07 '22 13:10 marcwrobel

@garydgregory ?

marcwrobel avatar Oct 18 '22 13:10 marcwrobel

@garydgregory ?

100+ files changed puts this on the todo list for the weekend most likely... and it will help if you don't conflict with https://github.com/apache/commons-collections/pull/335

garydgregory avatar Oct 18 '22 20:10 garydgregory

@garydgregory, will it help you if I split this PR into multiple smaller PRs ?

marcwrobel avatar Oct 19 '22 11:10 marcwrobel

That might be worse, it's just the same to review but spread out ;-)

garydgregory avatar Oct 19 '22 11:10 garydgregory

I resolved a conflict and rolled back the changes in files that were also changed in #335 (only two typos were rolled back). The two PRs should not conflict with each other.

marcwrobel avatar Oct 19 '22 12:10 marcwrobel

Hi @marcwrobel Please revert changes to the bloomfilter package, I don't want to make to make work for #335 TY

garydgregory avatar Oct 19 '22 22:10 garydgregory

@garydgregory, all changes related to the bloomfilter package have been reverted.

marcwrobel avatar Oct 20 '22 06:10 marcwrobel