Break Inherifance need for BulkTest constants

TransformedSplitMapTest break inheritance of BulkTest

IteratorIterableTest break inheritance of BulkTest

Break Inheritance need for AbstractObjectTest

Trying to reduce requirement for methods via inheritance, so breaking out common static or helper methods.

Mar 17 '22 15:03 nhojpatrick

Codecov Report

Merging #293 (93b0fd1) into master (f55268b) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #293   +/-   ##
=========================================
  Coverage     85.80%   85.80%           
  Complexity     4674     4674           
=========================================
  Files           292      292           
  Lines         13472    13472           
  Branches       1955     1955           
=========================================
  Hits          11560    11560           
  Misses         1332     1332           
  Partials        580      580

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f55268b...93b0fd1. Read the comment docs.

Mar 17 '22 15:03 codecov-commenter

Hi @nhojpatrick Please rebase. TY

Mar 18 '22 12:03 garydgregory

@garydgregory done, tests locally report

[WARNING] Tests run: 16937, Failures: 0, Errors: 0, Skipped: 4

so will look into the JDK 17 failures reported later

Mar 18 '22 17:03 nhojpatrick

@garydgregory EmptyPropertiesTest passes locally on JDK 17, and that class is not touched in this PR so not sure how to fix it.

Mar 19 '22 15:03 nhojpatrick

@garydgregory EmptyPropertiesTest passes locally on JDK 17, and that class is not touched in this PR so not sure how to fix it.

Ask yourself: Does the OS matter? Does the default EOL sequence matter? Does the default Charset matter? What else is different between my environment and the GutHub build environment?

Mar 28 '22 09:03 garydgregory

@nhojpatrick maybe https://github.com/apache/commons-collections/commit/b705855353272a1a50aee36cef21fb6bfbcc6da2 ?

Mar 28 '22 19:03 garydgregory

@nhojpatrick maybe b705855 ?

That commit only fix one of the flaky test, I previously raised https://github.com/apache/commons-collections/pull/306/ as testStoreToOutputStream() and testStoreToPrintWriter are still flaky but was told superseded

Jul 10 '22 04:07 samabcde

Hello @nhojpatrick Getting back to this... we no longer depend on JUnit 4 but there might still be clean-ups to do. Please see git master.

Jan 20 '24 15:01 garydgregory

[COLLECTIONS-806] Continue JUnit v5

Codecov Report