cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Allow VMWare import via another host

Open vishesh92 opened this issue 1 year ago • 29 comments

Description

This PR allows importing of a VM on VMWare via another host. This is useful in cases when import in the current cluster is not possible due to different versions of virt-v2v.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 avatar Oct 14 '24 06:10 vishesh92

@blueorangutan package

vishesh92 avatar Oct 14 '24 06:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 14 '24 06:10 blueorangutan

Codecov Report

Attention: Patch coverage is 57.79817% with 138 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (0602f46) to head (25da9a7). Report is 39 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../LibvirtImportConvertedInstanceCommandWrapper.java 57.06% 66 Missing and 16 partials :warning:
...loud/agent/api/ImportConvertedInstanceCommand.java 25.00% 18 Missing :warning:
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 79.76% 14 Missing and 3 partials :warning:
...cloud/agent/api/ImportConvertedInstanceAnswer.java 18.18% 9 Missing :warning:
.../wrapper/LibvirtConvertInstanceCommandWrapper.java 45.45% 5 Missing and 1 partial :warning:
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java 0.00% 3 Missing :warning:
...ava/com/cloud/agent/api/ConvertInstanceAnswer.java 0.00% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9787      +/-   ##
============================================
- Coverage     15.80%   15.12%   -0.68%     
- Complexity    11198    11251      +53     
============================================
  Files          5038     5407     +369     
  Lines        443852   473639   +29787     
  Branches      52578    57750    +5172     
============================================
+ Hits          70137    71655    +1518     
- Misses       365912   393986   +28074     
- Partials       7803     7998     +195     
Flag Coverage Δ
uitests 4.30% <ø> (?)
unittests 15.84% <57.79%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 14 '24 06:10 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11331

blueorangutan avatar Oct 14 '24 07:10 blueorangutan

@blueorangutan test

vishesh92 avatar Oct 14 '24 09:10 vishesh92

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Oct 14 '24 09:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 14 '24 18:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 14 '24 18:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11342

blueorangutan avatar Oct 14 '24 19:10 blueorangutan

[SF] Trillian test result (tid-11660) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47202 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9787-t11660-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_secured_to_nonsecured_vm_migration Error 393.89 test_vm_life_cycle.py

blueorangutan avatar Oct 14 '24 23:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 15 '24 09:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 15 '24 09:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11349

blueorangutan avatar Oct 15 '24 10:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 15 '24 10:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 15 '24 10:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11351

blueorangutan avatar Oct 15 '24 11:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 16 '24 08:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 16 '24 08:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11359

blueorangutan avatar Oct 16 '24 09:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 16 '24 12:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 16 '24 12:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11362

blueorangutan avatar Oct 16 '24 13:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 16 '24 15:10 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 16 '24 15:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11364

blueorangutan avatar Oct 16 '24 16:10 blueorangutan

@blueorangutan test

vishesh92 avatar Oct 17 '24 04:10 vishesh92

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Oct 17 '24 04:10 blueorangutan

[SF] Trillian test result (tid-11676) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47696 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9787-t11676-kvm-ol8.zip Smoke tests completed. 127 look OK, 6 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_nic_secondaryip_add_remove Failure 0.09 test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup Error 0.00 test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
test_01_verify_ipv6_network Failure 1.84 test_network_ipv6.py
test_delete_account Error 3.08 test_network.py
test_delete_network_while_vm_on_it Error 1.18 test_network.py
test_deploy_vm_l2network Error 1.21 test_network.py
test_l2network_restart Error 2.32 test_network.py
ContextSuite context=TestPortForwarding>:setup Error 3.58 test_network.py
ContextSuite context=TestPublicIP>:setup Error 5.75 test_network.py
test_reboot_router Failure 0.08 test_network.py
test_releaseIP Error 2.92 test_network.py
test_releaseIP_using_IP Error 2.97 test_network.py
test_01_secure_vm_migration Error 134.43 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.44 test_vm_life_cycle.py

blueorangutan avatar Oct 17 '24 18:10 blueorangutan

@blueorangutan package

vishesh92 avatar Oct 21 '24 07:10 vishesh92

@blueorangutan package

kiranchavala avatar Oct 23 '24 05:10 kiranchavala