Prepend VPC name to VPC network tier name

[abh1sar]

Description

Network tiers which belong to a VPC have their own individual names, in the networks tab they are listed with all other networks, in order to make it easier to identify those networks and correlate them with the VPCs. their names should be prepended with the name of the VPC they belong to.

This PR prepends VPC name to the network tier name using a delimiter. This feature can be enabled using a global setting which is disabled by default. The delimiter can also be changed using a global setting. " " by default.

Doc PR : https://github.com/apache/cloudstack-documentation/pull/445

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI
• [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (019f2c6) to head (27b393a). Report is 532 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	14.28%	6 Missing :warning:
...ain/java/com/cloud/network/NetworkServiceImpl.java	87.50%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9780     +/-   ##
===========================================
  Coverage     15.78%   15.78%             
- Complexity    12564    12568      +4     
===========================================
  Files          5627     5628      +1     
  Lines        492250   492266     +16     
  Branches      61405    63361   +1956     
===========================================
+ Hits          77710    77719      +9     
- Misses       406066   406072      +6     
- Partials       8474     8475      +1     

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	16.60% <58.82%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11304

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11308

[abh1sar]

@blueorangutan test

[blueorangutan]

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11644) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52798 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9780-t11644-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[alexandremattioli]

@abh1sar are there any documentation changes?

[abh1sar]

@abh1sar are there any documentation changes?

@alexandremattioli yes. https://github.com/apache/cloudstack-documentation/pull/445