apache
UI improvements
Description
This PR does multiple UI improvements
- Autofill vCenter host, datacenter and credentials while adding cluster using the zone wide value from vmware_data_center table
- Show Usage settings as a different pane in global settings
- Option to attach the volume to an instance during volume create.
- Show mgmt server's service ip in the details tab of Infrastructure -> Management server.
- Don't display create volume snapshot button in the Instance tab for KVM, if the instance is running and "kvm.snapshot.enabled" is false. (Also contains some code cleanup in storage.js)
- The name Recurring snapshots is used everywhere except for one place where 'Scheduled' snapshots is used in the Recurring Snapshots form. Change it to Recurring Snapshots.
- Reorder the Hypervisor list shown everywhere in order of popularity.
Items 1,3,4,5,6 are UI only changes, and can be tested with just the UI.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
Project coverage is 16.00%. Comparing base (
7e295ec) to head (c59c122). Report is 39 commits behind head on 4.20.
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #9773 +/- ##
============================================
- Coverage 16.14% 16.00% -0.15%
- Complexity 12972 13065 +93
============================================
Files 5639 5644 +5
Lines 494299 494915 +616
Branches 59909 59960 +51
============================================
- Hits 79789 79195 -594
- Misses 405685 406883 +1198
- Partials 8825 8837 +12
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.01% <ø> (-0.01%) |
:arrow_down: |
| unittests | 16.84% <8.33%> (-0.15%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11289
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9773 (QA-JID-461)
@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?
@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?
@DaanHoogland You are right. These items contain db changes for which full testing will be required 2. Show Usage settings as a different pane in global settings 7. Reorder the Hypervisor list shown everywhere in order of popularity.
For the rest of the items, ui testing is enough.
P.S I have added db changes to schema-41900to42000 for now. Will move it to schema-42000-42010 once CloudStack version changes to 4.20.1. Will keep this PR in draft until then.
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11315
@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11662) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49908 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t11662-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11407
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11465
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11467