check tags while fetching storage pool for importing vm

[vishesh92]

Description

This PR fixes https://github.com/apache/cloudstack/issues/9670

Will continue on this after https://github.com/apache/cloudstack/pull/9787.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI
• [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [x] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 52.23881% with 32 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (ed1b145) to head (5e3c0f5). Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	52.23%	17 Missing and 15 partials :warning:

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19    #9764   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11265    11272    +7     
=========================================
  Files          5408     5408           
  Lines        473900   473946   +46     
  Branches      57791    57809   +18     
=========================================
+ Hits          71705    71725   +20     
- Misses       394192   394203   +11     
- Partials       8003     8018   +15     

Flag	Coverage Δ
uitests	4.30% <ø> (+<0.01%)	:arrow_up:
unittests	15.85% <52.23%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11268

[sureshanaparti]

@vishesh92 check/fix unit tests.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11276

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11613) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51907 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9764-t11613-kvm-ol8.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	134.42	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.42	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	Failure	362.27	test_vm_schedule.py
test_05_rvpc_multi_tiers	Failure	482.80	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	482.81	test_vpc_redundant.py

[vishesh92]

CLGTM. Could you describe your tests @vishesh92 ?

I am still testing it. Let me make this PR as a draft for now.

[vishesh92]

There are some issues. I will continue on this after https://github.com/apache/cloudstack/pull/9787.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11909

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11954

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12013)

[blueorangutan]

[SF] Trillian test result (tid-12016) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44529 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9764-t12016-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	134.38	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.39	test_vm_life_cycle.py