cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard
verified publisher icon apache

custom AccessLogger

Open DaanHoogland opened this issue 1 year ago • 7 comments

Description

This PR...

Fixes: #9512 as it was only partially fixed in #9568. This PR addresses the access.log candor.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland avatar Sep 26 '24 12:09 DaanHoogland

Codecov Report

:x: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.35%. Comparing base (d4229d3) to head (cb21862). :warning: Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ils/src/main/java/com/cloud/utils/StringUtils.java 58.33% 10 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff              @@
##              main    #9733       +/-   ##
============================================
+ Coverage     3.63%   17.35%   +13.71%     
- Complexity       0    15187    +15187     
============================================
  Files          441     5883     +5442     
  Lines        36961   524497   +487536     
  Branches      6771    64004    +57233     
============================================
+ Hits          1344    91010    +89666     
- Misses       35457   423202   +387745     
- Partials       160    10285    +10125
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <58.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 26 '24 13:09 codecov[bot]

@sureshanaparti could you review/test?

DaanHoogland avatar Feb 11 '25 12:02 DaanHoogland

@blueorangutan package

DaanHoogland avatar Feb 11 '25 12:02 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 11 '25 13:02 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12408

blueorangutan avatar Feb 11 '25 14:02 blueorangutan

@blueorangutan test

DaanHoogland avatar Feb 11 '25 14:02 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Feb 11 '25 14:02 blueorangutan

[SF] Trillian test result (tid-12375) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53233 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9733-t12375-kvm-ol8.zip Smoke tests completed. 132 look OK, 2 have errors, 7 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.26 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.39 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.39 test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated Error 14.89 test_vm_life_cycle.py
all_test_vpc_redundant Skipped --- test_vpc_redundant.py
all_test_vpc_router_nics Skipped --- test_vpc_router_nics.py
all_test_vpc_vpn Skipped --- test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py
all_test_hostha_kvm Skipped --- test_hostha_kvm.py

blueorangutan avatar Feb 12 '25 05:02 blueorangutan

[SF] Trillian test result (tid-12389) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 55402 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9733-t12389-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.35 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated Error 17.13 test_vm_life_cycle.py

blueorangutan avatar Feb 14 '25 00:02 blueorangutan

@blueorangutan package

DaanHoogland avatar Aug 01 '25 12:08 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 01 '25 12:08 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14505

blueorangutan avatar Aug 01 '25 14:08 blueorangutan