Updated listStoragePools response - added new managed parameter
Description
This PR updates listStoragePools response - added new managed parameter.
Partially addresses #8731
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Manually, tested the listStoragePools API.
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
Project coverage is 15.08%. Comparing base (
0597def) to head (cc7d786). Report is 11 commits behind head on 4.19.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...om/cloud/api/query/dao/StoragePoolJoinDaoImpl.java | 0.00% | 9 Missing :warning: |
| ...e/cloudstack/api/response/StoragePoolResponse.java | 0.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9588 +/- ##
============================================
- Coverage 15.08% 15.08% -0.01%
+ Complexity 11184 11183 -1
============================================
Files 5406 5406
Lines 472915 472930 +15
Branches 60040 58313 -1727
============================================
- Hits 71345 71344 -1
- Misses 393626 393644 +18
+ Partials 7944 7942 -2
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.30% <ø> (ø) |
|
| unittests | 15.80% <0.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10840
@blueorangutan test
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11217) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 59495 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9588-t11217-kvm-ol8.zip Smoke tests completed. 128 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_10_attachAndDetach_iso | Failure |
816.90 | test_vm_life_cycle.py |
| test_04_deploy_vnf_appliance | Error |
92.71 | test_vnf_templates.py |
| test_04_deploy_vnf_appliance | Error |
92.71 | test_vnf_templates.py |
| test_05_delete_vnf_template | Error |
1.11 | test_vnf_templates.py |
| ContextSuite context=TestVnfTemplates>:teardown | Error |
1.20 | test_vnf_templates.py |
| test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Error |
367.95 | test_vpc_redundant.py |
| test_02_redundant_VPC_default_routes | Error |
360.64 | test_vpc_redundant.py |
| test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Error |
243.05 | test_vpc_redundant.py |
| test_04_rvpc_network_garbage_collector_nics | Error |
198.68 | test_vpc_redundant.py |
| test_05_rvpc_multi_tiers | Error |
290.63 | test_vpc_redundant.py |
| test_05_rvpc_multi_tiers | Error |
290.64 | test_vpc_redundant.py |
| test_01_VPC_nics_after_destroy | Error |
181.78 | test_vpc_router_nics.py |
| test_02_VPC_default_routes | Error |
182.79 | test_vpc_router_nics.py |
| test_01_redundant_vpc_site2site_vpn | Failure |
424.68 | test_vpc_vpn.py |
| test_01_vpc_site2site_vpn_multiple_options | Failure |
249.94 | test_vpc_vpn.py |
| test_01_vpc_site2site_vpn | Failure |
296.31 | test_vpc_vpn.py |
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10877
@blueorangutan test
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11260) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48865 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9588-t11260-kvm-ol8.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_secure_vm_migration | Error |
134.38 | test_vm_life_cycle.py |
| test_01_secure_vm_migration | Error |
134.39 | test_vm_life_cycle.py |
| test_01_vpc_site2site_vpn_multiple_options | Failure |
357.73 | test_vpc_vpn.py |