cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Global setting to allow/disallow users to force stop a vm

Open abh1sar opened this issue 1 year ago • 16 comments

Description

Fixes #6629

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

Screenshot from 2024-08-22 15-27-42 Screenshot from 2024-08-22 15-27-57 Screenshot from 2024-08-22 15-33-36

How Has This Been Tested?

How did you try to break this feature and the system with this change?

abh1sar avatar Aug 22 '24 10:08 abh1sar

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 15.57%. Comparing base (1e12a80) to head (1ccb94f). Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 16.66% 5 Missing :warning:
.../cloudstack/api/response/CapabilitiesResponse.java 0.00% 3 Missing :warning:
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 2 Missing :warning:
...k/api/command/user/config/ListCapabilitiesCmd.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9569      +/-   ##
============================================
+ Coverage     15.55%   15.57%   +0.02%     
- Complexity    12011    12056      +45     
============================================
  Files          5500     5506       +6     
  Lines        481889   482919    +1030     
  Branches      62240    61451     -789     
============================================
+ Hits          74966    75231     +265     
- Misses       398637   399376     +739     
- Partials       8286     8312      +26     
Flag Coverage Δ
uitests 4.17% <ø> (-0.01%) :arrow_down:
unittests 16.35% <15.38%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 10:08 codecov[bot]

@blueorangutan package

abh1sar avatar Aug 22 '24 11:08 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 22 '24 11:08 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10751

blueorangutan avatar Aug 22 '24 13:08 blueorangutan

@blueorangutan test

DaanHoogland avatar Aug 22 '24 13:08 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Aug 22 '24 13:08 blueorangutan

[SF] Trillian test result (tid-11144) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49951 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9569-t11144-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_isolate_network_FW_PF_default_routes_egress_true Failure 109.38 test_routers_network_ops.py

blueorangutan avatar Aug 23 '24 04:08 blueorangutan

@blueorangutan package

abh1sar avatar Aug 23 '24 09:08 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 23 '24 09:08 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 10777

blueorangutan avatar Aug 23 '24 10:08 blueorangutan

@blueorangutan package

abh1sar avatar Aug 23 '24 11:08 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 23 '24 11:08 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10780

blueorangutan avatar Aug 23 '24 12:08 blueorangutan

@blueorangutan test

DaanHoogland avatar Aug 26 '24 07:08 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Aug 26 '24 07:08 blueorangutan

[SF] Trillian test result (tid-11175) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 50884 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9569-t11175-kvm-ol8.zip Smoke tests completed. 139 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Aug 26 '24 22:08 blueorangutan