Fix resource count discrepancy while associating IP address to a network

[vishesh92]

Description

This PR fixes #9464

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI
• [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [x] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (1a403f1) to head (09f5680). Report is 32 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/network/IpAddressManagerImpl.java	0.00%	9 Missing :warning:
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.00%	8 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9563    +/-   ##
==========================================
  Coverage     15.08%   15.08%            
  Complexity    11181    11181            
==========================================
  Files          5406     5406            
  Lines        472915   472924     +9     
  Branches      58400    57903   -497     
==========================================
+ Hits          71336    71341     +5     
- Misses       393637   393641     +4     
  Partials       7942     7942            

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <0.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10731

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

@vishesh92 linked issue targeted for 4.19.2, can rebase this with 4.19 branch?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10750

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11142) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48166 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9563-t11142-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

before:

for i in 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 ; do   cmk associate ipaddress account=ACSUser domainid=0138c7b1-75d6-11ef-85da-1e00d40003a2 networkid=60a9f348-5d07-4614-a2b3-4422f48c4972 zoneid=93d46e79-8af4-429c-adec-da9500ab16ea ipaddress=10.0.54.$i & done 

leads to

after applying the patch I tried several times to get more than one IP address, with the above script, but failed.