apache
Add support for disabling serivce / system and disk offerings
Description
This PR addresses: https://github.com/apache/cloudstack/issues/8440
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
:x: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 15.81%. Comparing base (638c152) to head (590dc48).
:warning: Report is 1002 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9546 +/- ##
===========================================
Coverage 15.81% 15.81%
- Complexity 12539 12554 +15
===========================================
Files 5623 5629 +6
Lines 491606 492041 +435
Branches 59582 61524 +1942
===========================================
+ Hits 77725 77817 +92
- Misses 405562 405901 +339
- Partials 8319 8323 +4
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.48% <ø> (-0.02%) |
:arrow_down: |
| unittests | 16.60% <18.18%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10698
I am not sure if should allow deletion of offerings. This could potentially cause some issues when the offering being deleted is still in use by some other resource (e.g. CKS, autoscaling group, etc.) which could then result in NPE or some other errors.
I am not sure if should allow deletion of offerings. This could potentially cause some issues when the offering being deleted is still in use by some other resource (e.g. CKS, autoscaling group, etc.) which could then result in NPE or some other errors.
@vishesh92 Checks have been added to prevent deletion of offerings if there are any VMs or volumes using them
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10715
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10716
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10717
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11120) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 61948 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9546-t11120-kvm-ol8.zip Smoke tests completed. 124 look OK, 15 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_DeployVmAffinityGroup | Error |
1.40 | test_affinity_groups.py |
| ContextSuite context=TestDeployVirtioSCSIVM>:teardown | Error |
50.80 | test_deploy_virtio_scsi_vm.py |
| test_01_deploy_vm_from_direct_download_template_nfs_storage | Error |
37.60 | test_direct_download.py |
| ContextSuite context=TestDirectDownloadTemplates>:teardown | Error |
1.10 | test_direct_download.py |
| ContextSuite context=TestKubernetesCluster>:teardown | Error |
99.13 | test_kubernetes_clusters.py |
| test_01_non_strict_host_anti_affinity | Error |
3.58 | test_nonstrict_affinity_group.py |
| test_02_non_strict_host_affinity | Error |
3.60 | test_nonstrict_affinity_group.py |
| ContextSuite context=TestStorageTags>:teardown | Error |
225.51 | test_primary_storage.py |
| runTest | Error |
0.00 | test_reset_vm_on_reboot.py |
| runTest | Error |
0.00 | test_reset_vm_on_reboot.py |
| test_01_so_removal_resource_update | Error |
148.78 | test_resource_accounting.py |
| ContextSuite context=TestResourceNames>:teardown | Error |
31.37 | test_resource_names.py |
| ContextSuite context=TestCpuCapServiceOfferings>:teardown | Error |
37.76 | test_service_offerings.py |
| ContextSuite context=TestServiceOfferings>:teardown | Error |
177.12 | test_service_offerings.py |
| ContextSuite context=TestCreateTemplate>:setup | Error |
114.28 | test_templates.py |
| ContextSuite context=TestPublicIPUsage>:teardown | Error |
1.19 | test_usage.py |
| ContextSuite context=TestTemplateUsage>:teardown | Error |
27.08 | test_usage.py |
| ContextSuite context=TestVolumeUsage>:teardown | Error |
215.97 | test_usage.py |
| ContextSuite context=TestDeployVM>:teardown | Error |
150.23 | test_vm_life_cycle.py |
| test_01_secure_vm_migration | Error |
374.69 | test_vm_life_cycle.py |
| ContextSuite context=TestSecuredVmMigration>:teardown | Error |
43.31 | test_vm_life_cycle.py |
| ContextSuite context=TestVMSchedule>:teardown | Error |
371.73 | test_vm_schedule.py |
| test_08_resize_volume | Error |
124.22 | test_volumes.py |
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10762
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10763
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10767