cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

UI: Show applied search filters

Open vishesh92 opened this issue 1 year ago • 15 comments

Description

This PR adds the feature to show applied search filters in the UI.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 avatar Aug 13 '24 09:08 vishesh92

@blueorangutan ui

vishesh92 avatar Aug 13 '24 09:08 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 13 '24 09:08 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.58%. Comparing base (b429e84) to head (b0ea771). Report is 796 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9520      +/-   ##
============================================
+ Coverage     15.54%   15.58%   +0.03%     
- Complexity    11998    12039      +41     
============================================
  Files          5496     5502       +6     
  Lines        481522   482436     +914     
  Branches      60782    60585     -197     
============================================
+ Hits          74858    75178     +320     
- Misses       398376   398929     +553     
- Partials       8288     8329      +41     
Flag Coverage Δ
uitests 4.28% <ø> (+0.10%) :arrow_up:
unittests 16.36% <ø> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 13 '24 09:08 codecov[bot]

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-419)

blueorangutan avatar Aug 13 '24 09:08 blueorangutan

@blueorangutan ui

vishesh92 avatar Aug 13 '24 12:08 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 13 '24 12:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-420)

blueorangutan avatar Aug 13 '24 12:08 blueorangutan

@blueorangutan ui

vishesh92 avatar Aug 16 '24 07:08 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 16 '24 07:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-421)

blueorangutan avatar Aug 16 '24 08:08 blueorangutan

Search message not in sync with filters =>

diff-msg-shown

UUIDs loaded instead of name for Zone, Group in filter view (on close & re-open) - Check if selected names can be populated as before =>

uuid-loaded-on-filter-view uuid-loaded-on-filter-view-zone-and-group

sureshanaparti avatar Aug 16 '24 08:08 sureshanaparti

@blueorangutan ui

vishesh92 avatar Aug 27 '24 09:08 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 27 '24 09:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-434)

blueorangutan avatar Aug 27 '24 09:08 blueorangutan

@sureshanaparti , is your problem solved?

DaanHoogland avatar Aug 28 '24 07:08 DaanHoogland

@sureshanaparti , is your problem solved?

@sureshanaparti , is your problem solved?

yes, the response objects are different. so, there is separate implementation for listing & validation. is that correct @vishesh92

sureshanaparti avatar Sep 12 '24 12:09 sureshanaparti

Had a discussion with @rohityadavcloud offline. He had some remarks about the UI and we agreed revisit it later. Moved this 4.20.1.0 milestone for now.

vishesh92 avatar Sep 16 '24 09:09 vishesh92

@vishesh92 Any update on this?

Pearl1594 avatar Feb 12 '25 18:02 Pearl1594

@vishesh92 Any update on this?

also look at release branch and milestone, please.

DaanHoogland avatar Feb 13 '25 09:02 DaanHoogland

My bad @DaanHoogland I noticed the comment that it was to be targetted for 4.20.1 and the milestone also set to 4.20.1

Pearl1594 avatar Feb 14 '25 14:02 Pearl1594