cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

secstorage.nfs.version is not used in two scenarios

Open weizhouapache opened this issue 1 year ago • 7 comments

the NFS version is not considered in two scenarios

  • During systemvm template registration

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java#L87

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java#L436-L437

  • When cleanup diagnosis files

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java#L479-L481

the nfs version is set to null

ISSUE TYPE
  • Bug Report
COMPONENT NAME

CLOUDSTACK VERSION

CONFIGURATION
OS / ENVIRONMENT
SUMMARY
STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

weizhouapache avatar Jul 30 '24 08:07 weizhouapache

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1.

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer

Revellski avatar Jul 31 '24 06:07 Revellski

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1.

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer

that's good point @Revellski , thanks

we need to review all the operations which mount secondary storage on hosts or management servers, including

  • mount ISO
  • mount configdrive ISO
  • etc

weizhouapache avatar Jul 31 '24 12:07 weizhouapache

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

DaanHoogland avatar Aug 13 '24 13:08 DaanHoogland

also editting labels at the same time seems to clash :)

DaanHoogland avatar Aug 13 '24 13:08 DaanHoogland

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense. Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

JoaoJandre avatar Aug 13 '24 17:08 JoaoJandre

@weizhouapache I've created #9559 for the original issues. Regarding https://github.com/apache/cloudstack/issues/9469#issuecomment-2260390777, do we any time mount ISOs on the hypervisor hosts?

shwstppr avatar Aug 21 '24 07:08 shwstppr

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense. Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

I think there might be several checks , for example

  • copy from primary to secondary (extract volume ? take volume snapshot ?)
  • copy from secondary to primary (deploy vm from new template ? )
  • mount configdrive ISO

weizhouapache avatar Aug 21 '24 08:08 weizhouapache

I think there might be several checks , for example

* copy from primary to secondary (extract volume ? take volume snapshot ?)

* copy from secondary to primary (deploy vm from new template ? )

* mount configdrive ISO

Do we create new tickets for these @weizhouapache ? (and close this one!)

DaanHoogland avatar Nov 08 '24 09:11 DaanHoogland

I think there might be several checks , for example

* copy from primary to secondary (extract volume ? take volume snapshot ?)

* copy from secondary to primary (deploy vm from new template ? )

* mount configdrive ISO

Do we create new tickets for these @weizhouapache ? (and close this one!)

I did not check the scenarios, therefore cannot say if there are issues. closing this ticket as the two issues reported in the description have been addressed by #9559

thanks @shwstppr @DaanHoogland

weizhouapache avatar Nov 08 '24 10:11 weizhouapache