cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

remove offering button should not be shown if the action is not allowed

Open DaanHoogland opened this issue 1 year ago • 2 comments

ISSUE TYPE
  • Improvement Request
COMPONENT NAME

CLOUDSTACK VERSION
4.19
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

as described in https://github.com/apache/cloudstack/pull/9391#issuecomment-2228126972 remove backup offering should only be shown if remove backup offering is allowed. (i.e. not for dummy offering or any other that might disallow it.)

see also image

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

DaanHoogland avatar Jul 15 '24 10:07 DaanHoogland

@DaanHoogland in the given example in https://github.com/apache/cloudstack/pull/9391#issuecomment-2228126972, the backup offering could be deleted using the 'force' option. So, I think the remove offering button should still be shown. The error only gives the warning that using the 'force' option will delete all the backups. Please let me know your thoughts

abh1sar avatar Aug 21 '24 21:08 abh1sar

@DaanHoogland in the given example in #9391 (comment), the backup offering could be deleted using the 'force' option. So, I think the remove offering button should still be shown. The error only gives the warning that using the 'force' option will delete all the backups. Please let me know your thoughts

So you are saying we should not implement this at all, right @abh1sar ? If the functionality is consistant, I am fine with keeping it, but it seemed odd to me at the time (close at will)

DaanHoogland avatar Aug 22 '24 09:08 DaanHoogland