Support Projects in Userdata
Description
This PR attempts to fix #https://github.com/apache/cloudstack/issues/9332
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
Project coverage is 12.26%. Comparing base (
beebeed) to head (8410707). Report is 857 commits behind head on 4.19.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...src/main/java/com/cloud/api/ApiResponseHelper.java | 0.00% | 7 Missing :warning: |
| ...ache/cloudstack/api/response/UserDataResponse.java | 0.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9373 +/- ##
==========================================
Coverage 12.25% 12.26%
- Complexity 9318 9321 +3
==========================================
Files 4699 4699
Lines 414601 414612 +11
Branches 51421 51054 -367
==========================================
+ Hits 50829 50842 +13
+ Misses 357461 357457 -4
- Partials 6311 6313 +2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 12.26% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Pearl1594 alternatively we could backport #8656 to 4.18
some UI changes in this PR are still valid
Oh my bad - I didn't realize there was a fix on 4.19 - explains why we haven't been able to reproduce on 4.19 envs :D cc @DaanHoogland
I shall update this .. Thanks @weizhouapache
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
Issue seems to be fixed in 4.19.1 by: https://github.com/apache/cloudstack/pull/8656. PR no longer needed