cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

test_primary_storage_scope.py should only run with kvm, vmware and simulator

Open abh1sar opened this issue 1 year ago • 9 comments

Description

This PR fixes the smoke failure in test_primary_storage_scope.py when run with XenServer. #9315

[SF] Trillian test result (tid-10688)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41254 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10688-xenserver-71.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_scope_change	Error	0.07	test_primary_storage_scope.py

Zone wide storage pools are not supported with Xenserver so storage pool creation was failing during setup, and not cleaning up the created cluster. This causes cluster create to fail if the test is retried.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [x] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

abh1sar avatar Jul 01 '24 14:07 abh1sar

@blueorangutan package

abh1sar avatar Jul 01 '24 14:07 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 01 '24 14:07 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.05%. Comparing base (d797356) to head (e28e40f).

Additional details and impacted files
@@            Coverage Diff             @@
##               4.19    #9323    +/-   ##
==========================================
  Coverage     15.05%   15.05%            
- Complexity    11135    11138     +3     
==========================================
  Files          5405     5405            
  Lines        472353   472353            
  Branches      61429    60748   -681     
==========================================
+ Hits          71110    71129    +19     
+ Misses       393324   393302    -22     
- Partials       7919     7922     +3     
Flag Coverage Δ
uitests 4.27% <ø> (ø)
unittests 15.77% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 14:07 codecov[bot]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10227

blueorangutan avatar Jul 01 '24 15:07 blueorangutan

@blueorangutan test matrix

abh1sar avatar Jul 01 '24 16:07 abh1sar

@abh1sar a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Jul 01 '24 16:07 blueorangutan

[SF] Trillian Build Failed (tid-10702)

blueorangutan avatar Jul 01 '24 16:07 blueorangutan

[SF] Trillian Build Failed (tid-10704)

blueorangutan avatar Jul 01 '24 16:07 blueorangutan

[SF] Trillian Build Failed (tid-10703)

blueorangutan avatar Jul 01 '24 16:07 blueorangutan

[SF] Trillian Build Failed (tid-10714)

blueorangutan avatar Jul 02 '24 13:07 blueorangutan

[SF] Trillian Build Failed (tid-10715)

blueorangutan avatar Jul 02 '24 14:07 blueorangutan

@blueorangutan package

abh1sar avatar Jul 03 '24 04:07 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 03 '24 04:07 blueorangutan

[SF] Trillian test result (tid-10716) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47478 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10716-kvm-centos7.zip Smoke tests completed. 130 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_cancel_host_maintenace_with_migration_jobs Error 221.03 test_host_maintenance.py
test_hostha_kvm_host_fencing Error 115.74 test_hostha_kvm.py

blueorangutan avatar Jul 03 '24 05:07 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10235

blueorangutan avatar Jul 03 '24 05:07 blueorangutan

@blueorangutan test matrix

sureshanaparti avatar Jul 03 '24 10:07 sureshanaparti

@sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Jul 03 '24 10:07 blueorangutan

[SF] Trillian test result (tid-10719) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39955 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10719-xenserver-71.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jul 03 '24 22:07 blueorangutan

[SF] Trillian test result (tid-10720) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48510 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9323-t10720-vmware-67u3.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jul 04 '24 00:07 blueorangutan