apache
Add certificate validation to check headers
Description
This PR addresses the issue #9004 which is related to the validation of certificate during the upload operation for the start and end lines of the certificate.
In this PR we have added that validation and improved the error message reporting
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
Project coverage is 15.08%. Comparing base (
8d02e5f) to head (25be98d). Report is 145 commits behind head on 4.19.
| Files | Patch % | Lines |
|---|---|---|
| ...in/java/com/cloud/server/ManagementServerImpl.java | 0.00% | 17 Missing :warning: |
| ...amework/security/keystore/KeystoreManagerImpl.java | 0.00% | 11 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9255 +/- ##
============================================
+ Coverage 14.95% 15.08% +0.12%
- Complexity 11016 11180 +164
============================================
Files 5378 5406 +28
Lines 469930 472934 +3004
Branches 59422 58556 -866
============================================
+ Hits 70301 71336 +1035
- Misses 391842 393658 +1816
- Partials 7787 7940 +153
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.30% <ø> (+0.01%) |
:arrow_up: |
| unittests | 15.80% <0.00%> (+0.12%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9950
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9954
Please hold this PR for merging, waiting for the issue owner response
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10732
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10799
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[LL]Trillian test result (tid-6980) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44065 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9255-t6980-kvm-centos7.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_02_domain_admin_access | Failure |
0.20 | test_account_access.py |
| test_01_invalid_upgrade_kubernetes_cluster | Failure |
0.01 | test_kubernetes_clusters.py |
| test_02_upgrade_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_03_deploy_and_scale_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_04_autoscale_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_05_basic_lifecycle_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_06_delete_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_08_upgrade_kubernetes_ha_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_10_vpc_tier_kubernetes_cluster | Failure |
0.00 | test_kubernetes_clusters.py |
| test_11_test_unmanaged_cluster_lifecycle | Error |
0.00 | test_kubernetes_clusters.py |
| test_01_primary_storage_scope_change | Error |
0.07 | test_primary_storage_scope.py |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11204) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 43344 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9255-t11204-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|