cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

[WIP] Add vm instance id to volume usage record

Open sureshanaparti opened this issue 1 year ago • 3 comments

Description

This PR adds vm instance id to volume usage record, addresses #7399

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [x] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti avatar Jun 11 '24 10:06 sureshanaparti

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 11 '24 10:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 15.32%. Comparing base (acae5c5) to head (0ca37b4). Report is 75 commits behind head on 4.19.

:exclamation: Current head 0ca37b4 differs from pull request most recent head 92e72f1

Please upload reports for the commit 92e72f1 to get more accurate results.

Files Patch % Lines
...ma/src/main/java/com/cloud/event/UsageEventVO.java 0.00% 14 Missing :warning:
...java/com/cloud/usage/parser/VolumeUsageParser.java 0.00% 7 Missing :warning:
...a/src/main/java/com/cloud/usage/UsageVolumeVO.java 0.00% 3 Missing :warning:
...rc/main/java/com/cloud/usage/UsageManagerImpl.java 0.00% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9217      +/-   ##
============================================
+ Coverage     14.96%   15.32%   +0.35%     
- Complexity    11002    11652     +650     
============================================
  Files          5373     5452      +79     
  Lines        469309   476576    +7267     
  Branches      58607    58211     -396     
============================================
+ Hits          70231    73014    +2783     
- Misses       391304   395494    +4190     
- Partials       7774     8068     +294     
Flag Coverage Δ
uitests 4.20% <ø> (-0.10%) :arrow_down:
unittests 16.07% <6.89%> (+0.39%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 10:06 codecov[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 24 '24 12:06 github-actions[bot]

Fix is addressed in https://github.com/apache/cloudstack/pull/11531, no further work needed. Closing this.

sureshanaparti avatar Oct 10 '25 12:10 sureshanaparti