apache
pre-commit: enable `markdownlint` rule `MD018`
https://github.com/DavidAnson/markdownlint/blob/main/doc/md018.md
Description
This PR adds another check for our Markdown linter.
MD018/no-missing-space-atx No space after hash on atx style heading.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Ran locally:
pre-commit run --all-files
How did you try to break this feature and the system with this change?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 16.06%. Comparing base (
6a2c7b0) to head (c12a94d). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9134 +/- ##
============================================
- Coverage 16.90% 16.06% -0.85%
Complexity 12872 12872
============================================
Files 5248 5642 +394
Lines 461567 493973 +32406
Branches 54170 59895 +5725
============================================
+ Hits 78050 79351 +1301
- Misses 374880 405837 +30957
- Partials 8637 8785 +148
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.01% <ø> (?) |
|
| unittests | 16.90% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10276
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11335
@JoaoJandre , can we merge these linting changes (mostly by @jbampton ) during freeze? I don't think any of them have code changes. At least this one hasn't .
@JoaoJandre , can we merge these linting changes (mostly by @jbampton ) during freeze? I don't think any of them have code changes. At least this one hasn't .
@DaanHoogland I don't see why we would merge them during a freeze. Although they generally do not pose any risks (at least this one doesn't), they are also not really high priority, are they? I see no problem in waiting until we release to merge these.
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11867
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11903
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11919