cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

server,event: fix events for storage maintenance

Open shwstppr opened this issue 1 year ago • 6 comments

Description

Fixes #8495

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr avatar May 08 '24 08:05 shwstppr

@blueorangutan package

shwstppr avatar May 09 '24 06:05 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 09 '24 06:05 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9584

blueorangutan avatar May 09 '24 07:05 blueorangutan

@blueorangutan test

vishesh92 avatar May 09 '24 09:05 vishesh92

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar May 09 '24 09:05 blueorangutan

[SF] Trillian test result (tid-10199) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48698 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9056-t10199-kvm-centos7.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 411.64 test_events_resource.py
test_create_pvlan_network Error 0.09 test_pvlan.py
test_02_trigger_shutdown Failure 346.83 test_safe_shutdown.py

blueorangutan avatar May 09 '24 23:05 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.66%. Comparing base (87e7c57) to head (bc96bfa). Report is 39 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9056      +/-   ##
============================================
+ Coverage     14.96%   15.66%   +0.70%     
+ Complexity    10995    10990       -5     
============================================
  Files          5373     5010     -363     
  Lines        469005   439844   -29161     
  Branches      58953    52129    -6824     
============================================
- Hits          70198    68918    -1280     
+ Misses       391036   363299   -27737     
+ Partials       7771     7627     -144     
Flag Coverage Δ
uitests ?
unittests 15.66% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 18 '24 19:05 codecov[bot]

@kiranchavala can you please help here to verify this bug fix ?

harikrishna-patnala avatar Jun 11 '24 10:06 harikrishna-patnala

@blueorangutan package

harikrishna-patnala avatar Jun 11 '24 10:06 harikrishna-patnala

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 11 '24 10:06 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9863

blueorangutan avatar Jun 11 '24 11:06 blueorangutan