apache
Refactor configuration SystemVMDefaultHypervisor
Description
The configuration SystemVMDefaultHypervisor is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a String, which forces the user to type in the name of the chosen hypervisor, being subject to typos.
This configuration was refactored, allowing its value to be altered in runtime; besides, its input was converted to a select, in order to facilitate the process of choosing the new value.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
How Has This Been Tested?
I changed the values of the configurations and verified that the default hypervisors for new system vms changed accordingly
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9306
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-9929) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47242 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8934-t9929-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
300.66 | test_events_resource.py |
| test_01_events_resource | Error |
300.67 | test_events_resource.py |
| test_04_deploy_vm_for_other_user_and_test_vm_operations | Failure |
92.05 | test_network_permissions.py |
| ContextSuite context=TestNetworkPermissions>:teardown | Error |
1.45 | test_network_permissions.py |
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
:x: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 16.58%. Comparing base (f958896) to head (e66f4e9).
:warning: Report is 463 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...n/java/com/cloud/resource/ResourceManagerImpl.java | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8934 +/- ##
==========================================
Coverage 16.57% 16.58%
- Complexity 13986 14038 +52
==========================================
Files 5746 5758 +12
Lines 510859 511730 +871
Branches 62140 62215 +75
==========================================
+ Hits 84696 84871 +175
- Misses 416689 417386 +697
+ Partials 9474 9473 -1
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 3.90% <ø> (-0.01%) |
:arrow_down: |
| unittests | 17.48% <50.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10640
@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11102
@GaOrtiga @BryanMLima what is the status of this PR? @sureshanaparti @weizhouapache , any concerns to be dealt with?
@GaOrtiga @BryanMLima what is the status of this PR? @sureshanaparti @weizhouapache , any concerns to be dealt with?
It is ready for review.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11154
Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11158
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @GaOrtiga Can you check / resolve any conflicts in this PR branch.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
@GaOrtiga ,can you address this comment: https://github.com/apache/cloudstack/pull/8934#discussion_r1766224572 , please?
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15395