cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

cks: fix list apis response count

Open shwstppr opened this issue 2 years ago • 10 comments

Description

Fixes count value in listKubernetesClusters and listSupportedKubernetesVersions APIs response. Currently, it returns items count of the response

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr avatar Feb 23 '24 18:02 shwstppr

@blueorangutan package

shwstppr avatar Feb 23 '24 18:02 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 23 '24 18:02 blueorangutan

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8762

blueorangutan avatar Feb 23 '24 19:02 blueorangutan

@blueorangutan package

shwstppr avatar Feb 23 '24 19:02 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 23 '24 19:02 blueorangutan

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (cadbb56) to head (73e61b4). Report is 54 commits behind head on 4.19.

Files Patch % Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##               4.19    #8701       +/-   ##
=============================================
- Coverage     15.13%   14.96%    -0.18%     
+ Complexity    13469    10987     -2482     
=============================================
  Files          4863     5373      +510     
  Lines        326031   469026   +142995     
  Branches      45838    58668    +12830     
=============================================
+ Hits          49349    70177    +20828     
- Misses       270066   391082   +121016     
- Partials       6616     7767     +1151     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.31% <ø> (?)
unittests 15.66% <63.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 23 '24 19:02 codecov[bot]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8763

blueorangutan avatar Feb 23 '24 20:02 blueorangutan

@blueorangutan test

shwstppr avatar Feb 24 '24 02:02 shwstppr

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Feb 24 '24 02:02 blueorangutan

[SF] Trillian test result (tid-9324) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40751 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8701-t9324-kvm-centos7.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_migrate_vm Error 0.05 test_vm_life_cycle.py

blueorangutan avatar Feb 24 '24 13:02 blueorangutan

@blueorangutan package

shwstppr avatar Apr 18 '24 11:04 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 18 '24 11:04 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9310

blueorangutan avatar Apr 18 '24 13:04 blueorangutan

@blueorangutan package

shwstppr avatar May 24 '24 11:05 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 24 '24 11:05 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9698

blueorangutan avatar May 24 '24 13:05 blueorangutan

@blueorangutan test

shwstppr avatar May 24 '24 14:05 shwstppr

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar May 24 '24 14:05 blueorangutan

[SF] Trillian test result (tid-10282) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45618 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8701-t10282-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 341.75 test_safe_shutdown.py

blueorangutan avatar May 25 '24 03:05 blueorangutan

@kiranchavala can you please try giving a pagesize lesser than the number of resources present in the env?

shwstppr avatar Jun 12 '24 12:06 shwstppr

@kiranchavala here is an example in an env without fix (count should have been returned same [=3] in both case),

(local) 🐱 > list kubernetessupportedversions pagesize=2 page=1 filter=id,name
{
  "count": 2,
  "kubernetessupportedversion": [
    {
      "id": "6570218c-7d3f-478c-bb72-1c3c778aaf45",
      "name": "v1.26.0"
    },
    {
      "id": "b3e308be-e39b-4d9c-82d5-de41da9ed843",
      "name": "v1.24.0"
    }
  ]
}
(local) 🐱 > list kubernetessupportedversions filter=id,name
{
  "count": 3,
  "kubernetessupportedversion": [
    {
      "id": "6570218c-7d3f-478c-bb72-1c3c778aaf45",
      "name": "v1.26.0"
    },
    {
      "id": "b3e308be-e39b-4d9c-82d5-de41da9ed843",
      "name": "v1.24.0"
    },
    {
      "id": "04c74e5c-7802-460e-92b7-cce2b8efc546",
      "name": "v1.24.0"
    }
  ]
}

shwstppr avatar Jun 12 '24 12:06 shwstppr