cloudstack
cloudstack copied to clipboard
NSX: Cleanup PF rule when VM is expunged and fix UDP - LB rules
Description
This PR...
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 32.34%. Comparing base (
8c7c59f) to head (5a74c3e). Report is 30 commits behind head on nsx-integration.
| Files | Patch % | Lines |
|---|---|---|
| ...va/org/apache/cloudstack/service/NsxApiClient.java | 0.00% | 2 Missing :warning: |
| ...java/org/apache/cloudstack/service/NsxElement.java | 50.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## nsx-integration #8699 +/- ##
=====================================================
+ Coverage 30.89% 32.34% +1.44%
- Complexity 33460 36519 +3059
=====================================================
Files 5388 5391 +3
Lines 377567 396121 +18554
Branches 55032 62659 +7627
=====================================================
+ Hits 116664 128121 +11457
- Misses 245401 251084 +5683
- Partials 15502 16916 +1414
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 26.19% <0.00%> (+1.65%) |
:arrow_up: |
| uitests | 4.68% <ø> (+0.32%) |
:arrow_up: |
| unit-tests | 16.83% <25.00%> (+0.12%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Already present in https://github.com/apache/cloudstack/pull/7919