cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

ui: fix missing changes from #10814

Open shwstppr opened this issue 8 months ago • 5 comments

Description

Some changes from PR #10814 are missing in DeployVM and DeployVnf wizards causing warnings in teh browser console.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

Before:

Screenshot from 2025-06-19 14-16-37

After:

Launch button shows menu, image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr avatar Jun 19 '25 08:06 shwstppr

@blueorangutan ui

shwstppr avatar Jun 19 '25 08:06 shwstppr

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 19 '25 08:06 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.57%. Comparing base (5b7c3b4) to head (4c7ae7b). Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11060      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
- Complexity    13967    13968       +1     
============================================
  Files          5743     5743              
  Lines        510468   510470       +2     
  Branches      62073    62074       +1     
============================================
- Hits          84616    84615       -1     
- Misses       416390   416392       +2     
- Partials       9462     9463       +1     
Flag Coverage Δ
uitests 3.90% <ø> (-0.01%) :arrow_down:
unittests 17.47% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 19 '25 09:06 codecov[bot]

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11060 (QA-JID-649)

blueorangutan avatar Jun 19 '25 09:06 blueorangutan

merge forward errors become more frequesnt :( not sure I was the culprit but sorry anyway.

DaanHoogland avatar Jun 19 '25 09:06 DaanHoogland

verified in qa

DaanHoogland avatar Jun 23 '25 15:06 DaanHoogland