[CKS] Create Kubernetes ISO support for ARCH optional parameter
Description
CloudStack supports Multi-Arch zones #9619 since 4.20.
This PR introduces an optional parameter ARCH for the create-kubernetes-binaries-iso.sh script to include the corresponding arch binaries. Also, the generated ISO will include the ARCH on its name
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Tested three scenarios:
- Not passing the ARCH pameter -> observe the script downloads amd64 binaries on the ISO
- Passing ARCH=arm64 -> observe the script downloads arm64 binaries on the ISO
- Passing ARCH=aaarm -> ERROR
How did you try to break this feature and the system with this change?
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 16.57%. Comparing base (b57994e) to head (441cfc4).
:warning: Report is 142 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10986 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
Complexity 14059 14059
============================================
Files 5772 5772
Lines 512938 512938
Branches 62304 62304
============================================
- Hits 85026 85024 -2
- Misses 418431 418432 +1
- Partials 9481 9482 +1
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 3.89% <ø> (ø) |
|
| unittests | 17.47% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@blueorangutan package
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
To be consistent to the systemvm template and packages, I think it would be better to use the following in the ISO name
- x86_64
- aarch64
refer to https://download.cloudstack.org/systemvm/4.20/ and https://download.cloudstack.org/el/9/4.20/
yes, I know some other projects use amd64/arm64
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13684
Thanks @weizhouapache I have fixed the ISO naming
@blueorangutan package
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13692
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@nvazquez can you resolve the conflicts.
Thanks @sureshanaparti - conflicts fixed
@blueorangutan package
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14219
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14321
@blueorangutan test
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-13869) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 62359 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10986-t13869-kvm-ol8.zip Smoke tests completed. 142 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|