apache
[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated
Description
This PR ensures the converted/imported instances preserve the source VM boot mode and boot type.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
- Verify the source VM boot type and boot mode before importing:
- Import Vmware VM using KVM host for conversion having virt-v2v and ovftool installed
- Verify the imported VM contains the expected boot mode and boot type:
How did you try to break this feature and the system with this change?
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 16.15%. Comparing base (
8f2735a) to head (ce013d5). Report is 34 commits behind head on 4.20.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java | 60.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #10975 +/- ##
==========================================
Coverage 16.15% 16.15%
- Complexity 13273 13275 +2
==========================================
Files 5657 5656 -1
Lines 497898 497792 -106
Branches 60374 60370 -4
==========================================
+ Hits 80435 80440 +5
+ Misses 408505 408399 -106
+ Partials 8958 8953 -5
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.00% <ø> (+<0.01%) |
:arrow_up: |
| unittests | 17.01% <60.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13641
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
[SF] Trillian test result (tid-13475) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63409 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13475-vmware-70u3.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_deploy_more_vms_than_limit_allows | Error |
150.11 | test_deploy_vms_in_parallel.py |
| test_01_scale_vm | Error |
1.52 | test_scale_vm.py |
| test_02_scale_vm_negative_offering_disable_scaling | Error |
1.40 | test_scale_vm.py |
| test_03_scale_vm_negative_vm_disable_scaling | Error |
1.39 | test_scale_vm.py |
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13792
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14100
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14275
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
[SF] Trillian test result (tid-13833) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63560 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13833-vmware-70u3.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
Thanks @shwstppr for the review, comments addressed
@blueorangutan package
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14346