cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

polish: Fix some inconsistencies in object names and messages

Open abh1sar opened this issue 9 months ago • 7 comments

Description

This PR fixes some inconsistencies in object names and messages. doc pr : https://github.com/apache/cloudstack-documentation/pull/506

ACL Lists

  1. Replace ACL Lists with ACLs as Access Control List Lists doesn't make sense
  2. Replace Add ACL with Add ACL rule wherever a rule is being added

Before: Screenshot 2025-05-13 at 2 01 19 PM After: Screenshot 2025-05-13 at 2 01 31 PM Before: Screenshot 2025-05-13 at 2 03 00 PM After: Screenshot 2025-05-13 at 2 03 11 PM

User data

  1. Following industry conventions, User data should be written as two words
  2. The term "User Data" used in the main menu creates some confusion, whether it is singular or plural. So renamed it to "User Data Library" where users can register new User Data.
  3. User data should not be followed by "a"

Before: Screenshot 2025-05-13 at 2 04 42 PM After: Screenshot 2025-05-13 at 2 05 04 PM Before: Screenshot 2025-05-13 at 2 06 55 PM After: Screenshot 2025-05-13 at 2 07 21 PM

Use Title Case in main menu and create new * buttons

List of all changes done:
TitleCase.txt

Before: Screenshot 2025-05-13 at 2 09 37 PM After: Screenshot 2025-05-13 at 2 14 08 PM

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

abh1sar avatar May 13 '25 11:05 abh1sar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.15%. Comparing base (8f2735a) to head (87c0a24). Report is 33 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10856   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13273    13274    +1     
=========================================
  Files          5657     5656    -1     
  Lines        497898   497813   -85     
  Branches      60374    60373    -1     
=========================================
  Hits          80435    80435           
+ Misses       408505   408425   -80     
+ Partials       8958     8953    -5     
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) :arrow_up:
unittests 17.00% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 13 '25 11:05 codecov[bot]

@blueorangutan ui

abh1sar avatar Jun 05 '25 10:06 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 05 '25 10:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10856 (QA-JID-639)

blueorangutan avatar Jun 05 '25 10:06 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 10 '25 10:06 github-actions[bot]

@sureshanaparti to keep the scope of this PR manageable, I'll create a new PR later to handle all suggested label changes.

abh1sar avatar Jun 18 '25 10:06 abh1sar

@blueorangutan ui

abh1sar avatar Jun 18 '25 13:06 abh1sar

@blueorangutan ui

sureshanaparti avatar Jun 24 '25 11:06 sureshanaparti

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 24 '25 11:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10856 (QA-JID-653)

blueorangutan avatar Jun 24 '25 12:06 blueorangutan

@blueorangutan package

sureshanaparti avatar Jun 24 '25 12:06 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 24 '25 12:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13899

blueorangutan avatar Jun 24 '25 13:06 blueorangutan

@blueorangutan package

abh1sar avatar Jul 08 '25 09:07 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 08 '25 09:07 blueorangutan

I'll handle @sureshanaparti comments on generic label name changes on a different PR.

abh1sar avatar Jul 08 '25 10:07 abh1sar

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14091

blueorangutan avatar Jul 08 '25 12:07 blueorangutan

@blueorangutan ui

abh1sar avatar Jul 10 '25 07:07 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jul 10 '25 07:07 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10856 (QA-JID-662)

blueorangutan avatar Jul 10 '25 08:07 blueorangutan

@blueorangutan package

abh1sar avatar Jul 17 '25 03:07 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 17 '25 03:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14222

blueorangutan avatar Jul 17 '25 05:07 blueorangutan

@blueorangutan ui

abh1sar avatar Jul 23 '25 11:07 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jul 23 '25 11:07 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10856 (QA-JID-680)

blueorangutan avatar Jul 23 '25 11:07 blueorangutan

@blueorangutan package

sureshanaparti avatar Jul 23 '25 11:07 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 23 '25 11:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14314

blueorangutan avatar Jul 23 '25 13:07 blueorangutan

@blueorangutan test

sureshanaparti avatar Jul 23 '25 13:07 sureshanaparti