Removal of UI blockage to access the `changeOfferingForVolume` API
Description
This PR corrects an incorrect behavior in the UI where users who have access to the changeOfferingForVolume API, but are not admins, cannot use it.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
-
A role was created (based on the default user role) with permission to access the
changeOfferingForVolumeAPI. -
An account and a user were created using this role.
-
The
changeOfferingForVolumeAPI icon appeared correctly in the UI (npm run server). -
The change in the volume offer was made correctly
@blueorangutan ui
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 16.30%. Comparing base (0934fb1) to head (376bd4f).
:warning: Report is 574 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10135 +/- ##
============================================
- Coverage 16.30% 16.30% -0.01%
+ Complexity 13450 13447 -3
============================================
Files 5675 5675
Lines 499249 499249
Branches 60377 60377
============================================
- Hits 81425 81420 -5
- Misses 408753 408757 +4
- Partials 9071 9072 +1
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 3.99% <ø> (ø) |
|
| unittests | 17.16% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-504)
@blueorangutan ui
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-638)
@blueorangutan package
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14654
@shwstppr @weizhouapache , are you gouys alright with this to merge now?