cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Removal of UI blockage to access the `changeOfferingForVolume` API

Open LayonRibeiro opened this issue 1 year ago • 7 comments

Description

This PR corrects an incorrect behavior in the UI where users who have access to the changeOfferingForVolume API, but are not admins, cannot use it.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

Before

2024-12-22_23-01

After

2024-12-22_23-02

How Has This Been Tested?

  1. A role was created (based on the default user role) with permission to access the changeOfferingForVolume API.

  2. An account and a user were created using this role.

  3. The changeOfferingForVolume API icon appeared correctly in the UI (npm run server).

  4. The change in the volume offer was made correctly

LayonRibeiro avatar Dec 23 '24 12:12 LayonRibeiro

@blueorangutan ui

shwstppr avatar Dec 26 '24 05:12 shwstppr

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Dec 26 '24 05:12 blueorangutan

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 16.30%. Comparing base (0934fb1) to head (376bd4f). :warning: Report is 574 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10135      +/-   ##
============================================
- Coverage     16.30%   16.30%   -0.01%     
+ Complexity    13450    13447       -3     
============================================
  Files          5675     5675              
  Lines        499249   499249              
  Branches      60377    60377              
============================================
- Hits          81425    81420       -5     
- Misses       408753   408757       +4     
- Partials       9071     9072       +1     
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 17.16% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 26 '24 05:12 codecov[bot]

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-504)

blueorangutan avatar Dec 26 '24 05:12 blueorangutan

@blueorangutan ui

sureshanaparti avatar Jun 05 '25 09:06 sureshanaparti

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 05 '25 09:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-638)

blueorangutan avatar Jun 05 '25 09:06 blueorangutan

@blueorangutan package

RosiKyu avatar Aug 17 '25 07:08 RosiKyu

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 17 '25 07:08 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14654

blueorangutan avatar Aug 17 '25 09:08 blueorangutan

@shwstppr @weizhouapache , are you gouys alright with this to merge now?

DaanHoogland avatar Oct 13 '25 08:10 DaanHoogland