cloudstack-terraform-provider icon indicating copy to clipboard operation
cloudstack-terraform-provider copied to clipboard

service and disk offerings

Open poddm opened this issue 2 years ago • 14 comments

Enhanced the following resources to support the full api spec.

  • cloudstack_disk_offering
  • cloudstack_service_offering_constrained
  • cloudstack_service_offering_unconstrained
  • cloudstack_service_offering_fixed

I split the service offering API up into multiple resources to make it a bit clearer of the different qos types

poddm avatar Jan 04 '24 22:01 poddm

Hi @rohityadavcloud, any tentative timelines when v0.5.0 would release? Already merged features could be of a lot of use 😄

adidiborg avatar Feb 12 '24 16:02 adidiborg

Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometime in coming months.

Anybody in the community can work to become a committer and PMC member, and lead release work who work in their "free" time, and it's highly encouraged that users and organisations participate and sponsor their team to work in the community. It's often seen many interested individuals and organisations come together to work on their features and sometimes releases, and often some organisations sponsor feature and maintenance work, and collaborate for testing and release work but not just limited to coding but also documentation, website, marketing and events.

Everyone is welcome to start discussions on our dev@ and users@ mailing lists, in fact your comment would be more visible on the lists unless it was only specifically for me.

yadvr avatar Feb 13 '24 05:02 yadvr

Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometime in coming months.

Anybody in the community can work to become a committer and PMC member, and lead release work who work in their "free" time, and it's highly encouraged that users and organisations participate and sponsor their team to work in the community. It's often seen many interested individuals and organisations come together to work on their features and sometimes releases, and often some organisations sponsor feature and maintenance work, and collaborate for testing and release work but not just limited to coding but also documentation, website, marketing and events.

Everyone is welcome to start discussions on our dev@ and users@ mailing lists, in fact your comment would be more visible on the lists unless it was only specifically for me.

thanks for responding, I will also try to contribute whereever I can

adidiborg avatar Feb 13 '24 06:02 adidiborg

Update - I'd still like to get these merged once the cloudstack SDK is updated.

  • https://github.com/apache/cloudstack-terraform-provider/pull/71
  • https://github.com/apache/cloudstack-terraform-provider/issues/101

poddm avatar Apr 26 '24 02:04 poddm

@poddm can you address conflicts on your PR?

yadvr avatar Apr 26 '24 04:04 yadvr

@fabiomatavelli @kiranchavala @poddm Can we come to an agreement on service_offerings between this PR and what @fabiomatavelli had worked on here #113 and move forward with one of these solutions? This is starting to become an issue for me to be able to manage service offerings for our customers and this would be a huge help to be able to create less offerings because of being able to have offerings that are more dynamic to use.

P.S. @kiranchavala I would like to see a new release this quarter (end of Aug would be nice :smile: ) What can we do to help move the release of a version?

cc: @rohityadavcloud

CodeBleu avatar Aug 14 '24 15:08 CodeBleu

I can remove cloudstack_disk_offering to not conflict with the other changes.

I'd like to keep the separate types to align the GUI presentation and make it easier to understand what fields are required.

  • cloudstack_service_offering_constrained
  • cloudstack_service_offering_unconstrained
  • cloudstack_service_offering_fixed

poddm avatar Aug 14 '24 15:08 poddm

@poddm @fabiomatavelli I was on vacation so couldn't reply earlier.

Longer term, since you're both active contributors and if you want to main and drive releases yourselves I can propose you both as committers after which you can propose yourself to be release managers (did some write up here on the typical release process: https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BDRAFT%5D+How+to+Become+a+CloudStack+Release+Manager ) - let me know if you're interested to do that.

Looking at $dayjob pile and on-going community work, I think most of us will busy this/next month working towards the upcoming ACS 4.20 and other misc releases. We'll be available most likely in end of Q3 or in Q4 for the next ACS Terraform (Tofu) Provider releases.

Meanwhile, feel free to work on stabilising the PRs & overall main branch to be ready for release work and continue to build/use the snapshots as required. I've pinged @kiranchavala @vishesh92 who can assist with review related queries.

yadvr avatar Aug 22 '24 06:08 yadvr

@rohityadavcloud, I'm interested.

poddm avatar Aug 22 '24 15:08 poddm

@poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

vishesh92 avatar Aug 23 '24 10:08 vishesh92

@poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

@vishesh92 I don't believe the comment about "removing existing resource types" is what you think. I understood it to mean he would remove his changes in this PR that are not related to the "service offerings" resource.

Also, @poddm if we are moving forward with your approach, can we use the new terraform plugin framework approach? #113 I think we should start moving to using that for new/updated resources. Then eventually we can get to upgrading the rest to use the new framework.

CodeBleu avatar Aug 23 '24 13:08 CodeBleu

@poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

@vishesh92 I don't believe the comment about "removing existing resource types" is what you think. I understood it to mean he would remove his changes in this PR that are not related to the "service offerings" resource.

Also, @poddm if we are moving forward with your approach, can we use the new terraform plugin framework approach? #113 I think we should start moving to using that for new/updated resources. Then eventually we can get to upgrading the rest to use the new framework.

@poddm @vishesh92 @rohityadavcloud

Is there anything I can help with to get this merged? I'm desperately needing to have this avail, so I can pass this on to our customers and help reduce a lot of manual management of service offerings.

CodeBleu avatar Sep 13 '24 15:09 CodeBleu

I missed these previous messages. Let me look at refactoring this into the new framework SDK.

poddm avatar Sep 13 '24 15:09 poddm