cloudstack-cloudmonkey icon indicating copy to clipboard operation
cloudstack-cloudmonkey copied to clipboard
verified publisher icon apache

Use ergochat/readline

Open vishesh92 opened this issue 3 months ago • 4 comments

Fixes https://github.com/apache/cloudstack-cloudmonkey/issues/137 and removes vendor directory.

vishesh92 avatar Nov 03 '25 11:11 vishesh92

✅ Build complete for PR #199.

🔗 Download the cmk binaries (expires on November 16, 2025)

github-actions[bot] avatar Nov 03 '25 11:11 github-actions[bot]

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change. One I did was to allow autocompletion by name of the resources

shwstppr avatar Nov 04 '25 15:11 shwstppr

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change. One I did was to allow autocompletion by name of the resources

Let me compare with the upstream readline library. Do you know if there is any other library which was changed? We should ideally move away from vendor based setup.

vishesh92 avatar Nov 04 '25 16:11 vishesh92

@shwstppr I have migrated the changes in readline package to the new one and keeping the vendors directory.

vishesh92 avatar Nov 05 '25 09:11 vishesh92