cayenne icon indicating copy to clipboard operation
cayenne copied to clipboard

disjoint prefetch returns incorrect data [failing tests]

Open johnthuss opened this issue 1 year ago • 1 comments

disjoint and disjointById prefetches over 2 hops with both hops prefetched returns incorrect data

johnthuss avatar Oct 17 '24 20:10 johnthuss

Did a bit of digging. This is an older problem it seems, it's present at least in 4.2 and 4.1. An issue really in the combination of prefetch types, from all possible combination in this case, only two failed (joint + not joint).

Finally, joint + disjoint and joint + disjointById cases seem slightly separate problems (or I didn't dig enough). I got a rough fix for the first case and it isn't affecting the second.

stariy95 avatar Oct 18 '24 12:10 stariy95

If you have a partial or complete fix for this issue, I'd be interested to see it. Could you share it? Thanks!

johnthuss avatar Oct 28 '25 18:10 johnthuss

@johnthuss here's what I believe is a partial fix: https://github.com/stariy95/cayenne/commit/c4d57b7da7a8f70a0ee660bd334b88d1c0308a57#diff-0302f005474d7e346cd7a639c67d41c3496029316a1ce68daf08d757a8186e84L104

It seems fix disjoint but not disjointById prefetch

stariy95 avatar Oct 28 '25 19:10 stariy95

Thanks! I added support for that last case (joint+disjointById) now and the tests are passing.

johnthuss avatar Oct 29 '25 14:10 johnthuss