Cassandra 16092: CEP-7 port Index Group for Storage Attached Index

[jasonstack]

J8 CI: https://app.circleci.com/pipelines/github/jasonstack/cassandra/354/workflows/11455522-9940-4bcc-b15a-3ec6aa5f5c7f J11 CI: https://app.circleci.com/pipelines/github/jasonstack/cassandra/354/workflows/67472aa4-44fd-4079-8fa0-3b243e7bab77

[jasonstack]

pushed a WIP rebased version for CI.. Will double check later

j8: https://app.circleci.com/pipelines/github/jasonstack/cassandra/343/workflows/43fd8122-6ffb-4f72-86d6-afa3283494ee j11: https://app.circleci.com/pipelines/github/jasonstack/cassandra/343/workflows/39b260ed-0c64-45c0-8c51-a3de7b50d0b9

[jasonstack]

https://app.circleci.com/pipelines/github/jasonstack/cassandra/346/workflows/52d3b98f-cf0a-4a5e-bee3-cbb1b372c8c3

[maedhroz]

Tests look clean so far... CASTest was certainly flaky before this patch.

[spuds51]

unsubscribe

------ Original Message ------ From: "Caleb Rackliffe" @.> To: "apache/cassandra" @.> Cc: "Subscribed" @.***> Sent: 5/18/2021 3:39:16 PM Subject: Re: [apache/cassandra] Cassandra 16092: CEP-7 port Index Group for Storage Attached Index (#735)

@.*** commented on this pull request.

---

In src/java/org/apache/cassandra/db/ReadCommand.java https://github.com/apache/cassandra/pull/735#discussion_r634693279:

•        return kind.selectionDeserializer.deserialize(in, version, isDigest, digestVersion, acceptsTransient, metadata, nowInSec, columnFilter, rowFilter, limits, index);
  

•        Index.QueryPlan indexQueryPlan = null;
  

•        if (hasIndex)
  

•        {
  

•            IndexMetadata index = deserializeIndexMetadata(in, version, metadata);
  

•            Index.Group indexGroup =  Keyspace.openAndGetStore(metadata).indexManager.getIndexGroup(index);
  

•            if (indexGroup != null)
  

•                indexQueryPlan = indexGroup.queryPlanFor(rowFilter);
  

•        }
  

•        return kind.selectionDeserializer.deserialize(in, version, isDigest, digestVersion, acceptsTransient, metadata, nowInSec, columnFilter, rowFilter, limits, indexQueryPlan);
  

We didn't actually change what gets sent over the wire here, but it might be a good idea to have at least a basic UpgradeTestBase test that fires off some index queries in a mixed v3X/v4 cluster (and, of course, actually hits these codepaths).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apache/cassandra/pull/735#pullrequestreview-662501396, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEDDZR7HSG7PEELYPAZHQDTOK66JANCNFSM4Q4RZ7PQ.

[jasonstack]

sorry for the delay, I will address all the feedback and pull in the latest SAI interface, then ping you for review

[maedhroz]

Cherry-picked to https://github.com/apache/cassandra/pull/1466