cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

CASSANDRA-15510 (4.0): Optimise BTree.{build,update,transform}

Open blerer opened this issue 3 years ago • 4 comments

blerer avatar Feb 19 '22 15:02 blerer

Called it nonEmptyParentMaybeSteal and changed touch to inUse. I didn't reset it to false to avoid risking uncleaned arrays after use.

I did mentally wonder about this after proposing it (without checking) and figured if that were the case we could easily introduce two flags used (or touched) and inUse - set both on touch and unset only inUse when empty.

belliottsmith avatar Mar 18 '22 13:03 belliottsmith

Modulo rolling that one errant change I suggested back, LGTM +1

belliottsmith avatar Apr 07 '22 14:04 belliottsmith

Rollback pushed to the same branch.

blambov avatar Apr 07 '22 15:04 blambov

Perfect. I think I broke Jira with all my worklog updates - at least, I cannot load the page successfully now - so I'll just leave my +1 here.

belliottsmith avatar Apr 07 '22 15:04 belliottsmith