camel icon indicating copy to clipboard operation
camel copied to clipboard

CAMEL-20717 Throw created exception in TcpSocketConsumerRunnable

Open dk2k opened this issue 1 year ago • 2 comments

CAMEL-20717 Throw created exception in TcpSocketConsumerRunnable

dk2k avatar Apr 26 '24 18:04 dk2k

:star2: Thank you for your contribution to the Apache Camel project! :star2:

:robot: CI automation will test this PR automatically.

:camel: Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • :warning: Be careful when sharing logs. Review their contents before sharing them publicly.

github-actions[bot] avatar Apr 26 '24 18:04 github-actions[bot]

Ah I think the exception should actually not be thrown but just removed, as the idea is that in case of timeout the handle method is triggered, but the run method should keep running. So instead can you just remove the exception.

davsclaus avatar Apr 28 '24 11:04 davsclaus

You need to remove this line too

import org.apache.camel.component.mllp.MllpInvalidMessageException;

davsclaus avatar May 01 '24 04:05 davsclaus

removed the import

dk2k avatar May 01 '24 13:05 dk2k