camel-spring-boot icon indicating copy to clipboard operation
camel-spring-boot copied to clipboard

CAMEL-18341 - Upgrade from Codehaus Groovy 3.0.12 to Apache Groovy 4.0.4

Open apupier opened this issue 3 years ago • 6 comments

might worth merging at same time than https://github.com/apache/camel/pull/8102

Currently have this build error:

[ERROR] Failed to execute goal org.apache.camel.springboot:camel-spring-boot-generator-maven-plugin:3.19.0-SNAPSHOT:generate-dependencies-bom (default) on project camel-spring-boot-dependencies-generator: Found 4 conflicts between the current managed dependencies and the external BOMS:
[ERROR]  - org.codehaus.groovy:groovy-ant:jar
[ERROR]  - org.codehaus.groovy:groovy-jsr223:jar
[ERROR]  - org.codehaus.groovy:groovy-xml:jar
[ERROR]  - org.codehaus.groovy:groovy:jar
[ERROR] -> [Help 1]

I do not find other references in this project. Can it be that it needs to be updated in apache/camel project first? But it will break the build if we start merging the apache/camel and not apache/camel-spring-boot . Wondering how I can test locally with new version of apache/camel, run in offlien mode locally after build of apache/camel? (even if I would have expected that it picked the latest locally built) Or is it a real problem in another project?

apupier avatar Aug 03 '22 12:08 apupier

(the failur eon the Pull request buidl seems not related to this Pull request)

apupier avatar Aug 03 '22 12:08 apupier

There is some "weird" code somewhere in camel-spring-boot that aligns camel dependency versions vs spring boot versions and then fail if something is not aligned.

So it seems that spring boot groovy is on 3.x and when you upgrade to 4.x they dont match.

davsclaus avatar Aug 03 '22 13:08 davsclaus

image

So would mean that Spring Boot would need to upgrade to groovy 4.x before we can upgrade in Camel?

apupier avatar Aug 03 '22 13:08 apupier

sounds they did it for Spring 3.x https://github.com/spring-projects/spring-boot/issues/31631 3.0.0 GA is planned for end of November https://github.com/spring-projects/spring-boot/milestone/240

apupier avatar Aug 03 '22 13:08 apupier

Yes we need both quarkus and spring boot to upgrade to groovy 4

davsclaus avatar Aug 03 '22 13:08 davsclaus

reported https://github.com/quarkusio/quarkus/issues/27111 for Quarkus

apupier avatar Aug 03 '22 13:08 apupier

https://github.com/apache/camel-spring-boot/pull/774

davsclaus avatar Mar 09 '23 10:03 davsclaus