calcite icon indicating copy to clipboard operation
calcite copied to clipboard
verified publisher icon apache

[CALCITE-5634] Enable GREATEST, LEAST functions in PostgreSQL library

Open normanj-bitquill opened this issue 1 year ago • 5 comments

  • Add new GREATEST and LEAST functions for PostgreSQL
  • The new functions only return null if all arguments are null
  • Created a new library for RedShift since it is not truly a union of Oracle and PostgreSQL functions

normanj-bitquill avatar Jun 21 '24 20:06 normanj-bitquill

What's the relationship with #3142?

mihaibudiu avatar Jun 21 '24 20:06 mihaibudiu

@mihaibudiu I'll split this as you suggest. The RedShift library change will go into a new PR.

normanj-bitquill avatar Jun 21 '24 21:06 normanj-bitquill

@mihaibudiu This PR is now based on top of https://github.com/apache/calcite/pull/3829

When 3829 is merged in, I can rebase this off of main.

normanj-bitquill avatar Jun 21 '24 22:06 normanj-bitquill

In any case, I will review this again after it's rebased on #3829

mihaibudiu avatar Jun 24 '24 22:06 mihaibudiu

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 08 '24 16:07 sonarqubecloud[bot]

The commits have been squashed.

normanj-bitquill avatar Jul 08 '24 18:07 normanj-bitquill