calcite [CALCITE-6431] Implement the SINGLE_VALUE aggregation in HiveSqlDiale…

…ct And SparkSQLDialect

Jun 08 '24 03:06 NobiGo

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Jun 08 '24 23:06 sonarqubecloud[bot]

There are lots of changes in the quoting of identifiers. Is this a bug that is being fixed? If so, can it be a separate PR?

Jun 10 '24 18:06 mihaibudiu

There are lots of changes in the quoting of identifiers. Is this a bug that is being fixed? If so, can it be a separate PR?

Yes,If we don't add the quating, Spark will parse failed the alias $f0, So we need add this. And Others database dialect almost have added this. Of course, We can separate this PR.

Jun 11 '24 00:06 NobiGo

Can you make a separate issue about quoting then? Too many unrelated changes in this PR.

Jun 11 '24 00:06 mihaibudiu

Can you make a separate issue about quoting then? Too many unrelated changes in this PR.

Please check the CALCITE-6434.

Jun 11 '24 22:06 NobiGo

why is this a draft?

Jun 18 '24 17:06 mihaibudiu

why is this a draft?

Hi @mihaibudiu . I have add comment in the JIRA. This SQL can't run as expected in Spark And Hive.

Jun 18 '24 21:06 NobiGo